🐛 Improve MHC validation for topology-managed MHC #7498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
killianmuldoon
commented
Nov 4, 2022
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
mhc/improve-validation
branch
from
f1b5061 to
61d623e
Compare
killianmuldoon
changed the title
sbueringer
reviewed
Nov 8, 2022
killianmuldoon
force-pushed
the
mhc/improve-validation
branch
2 times, most recently
from
55f6dce to
928b779
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @fabriziopandini |
|
/retest |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
mhc/improve-validation
branch
from
928b779 to
667b272
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
Add validation for nodeStartupTimeout on cluster creation. Merge MHC validation into a single function in the MHC api definition which can then be used for common validation no matter if the MHC is defined in the Cluster topology, the ClusterClass or an individuation MHC object.