✨ Update ginkgo (2.2.0 -> 2.4.0) and gomega (1.20.1 -> 1.22.1) #7490
Conversation
k8s-ci-robot
added
cncf-cla: yes
oscr
force-pushed
the
update-ginkgo-2.4.0
branch
from
b902b98 to
e1e22e8
Compare
k8s-ci-robot
added
size/L
|
/test ? |
|
@oscr: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-main |
|
Failed due to: /test pull-cluster-api-e2e-full-main |
| @@ -47,7 +47,7 @@ The default value is 0, meaning that the volume can be detached without any time | |||
|
|
|||
| - The Kubernetes default registry has been changed from `k8s.gcr.io` to `registry.k8s.io`. Kubernetes image promotion currently publishes to both registries. Please | |||
| consider publishing manifests which reference the controller images from the new registry (for reference [Cluster API PR](https://github.com/kubernetes-sigs/cluster-api/pull/7478)). | |||
| - e2e tests are upgraded to use Ginkgo v2 (v2.2.0) and Gomega v1.20.1. Providers who use the test framework from this release will also need to upgrade, because Ginkgo v2 can't be imported alongside v1. Please see the [Ginkgo upgrade guide](https://onsi.github.io/ginkgo/MIGRATING_TO_V2), and note: | |||
| - e2e tests are upgraded to use Ginkgo v2 (v2.4.0) and Gomega v1.22.1. Providers who use the test framework from this release will also need to upgrade, because Ginkgo v2 can't be imported alongside v1. Please see the [Ginkgo upgrade guide](https://onsi.github.io/ginkgo/MIGRATING_TO_V2), and note: | |||
There was a problem hiding this comment.
Just to make sure, does this require any changes from providers? If so, it should go through our approval process (defined in https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/developer/release-cycle.md#release-cycle)
All changes that impact providers' adoption of the new release should be announced in the provider updates section of the office hours meeting notes and approved in the PR or issue by both approvers and key affected providers
No objections from my end, just thought I'd point it out since the migration guide is being updated and we the beta release has already been published.
There was a problem hiding this comment.
Good point and a good opportunity to refine further what "impact provider's adoption" means.
In my opinion changing dependencies ~ minor/pach version should be fine (I wouldn't bump k8s.io/, CR minor versions as they are not semver minor versions) even without approval as long as providers don't have to make code changes for that. If they would have to it should go through the approval process.
This means we would be fine with the fact that after providers are bumping to another beta and they are running go mod tidy some dependencies in their go.mod file change as well.
I looked through the release notes and they look good and non-disruptive to me.
That we didn't have to change anything in the test-framework or our e2e tests is another data point.
(gomega 1.23 would have made changes necessary > #7460 (comment))
There was a problem hiding this comment.
Thank you for raising this important question Cécile. It's a great point. I also fully agree with Stefans excellent comment.
k8s-ci-robot
added
the
lgtm
|
lgtm pending resolution of #7490 (comment) |
|
Thx @oscr for opening this PR! I think we should make sure we have relatively up-to-date dependencies in our minor releases. Might be worth checking some of our other dependencies |
|
@sbueringer Sounds great! Would you like it in this or another pr? |
Separate PR would be good. Thank you! |
No problem. I will get it done as soon as this merges to avoid having multiple prs changing the same files. |
If you have time, can you already take a look what would change and maybe open a WIP-PR? (you could build it on top of this PR for simplicity) Because depending on how much impact it has we have to discuss it in office hours again and in case we hold back this PR until Wednesday we would probably not have enough time to discuss other bumps before the RC on 15th November |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Updates gingko to 2.4.0, which also means bumping gomega to 1.22.1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #