-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Implement single-node cluster self-hosted upgrade test #7387
🌱 Implement single-node cluster self-hosted upgrade test #7387
Conversation
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-apidiff-main |
Great to seems multiple efforts coming together so nicely! |
We could do it and this would require changes to the Given that I wouldn't run a test specifically for Runtime SDK + SNC the only benefit would be to keep the two ClusterClasses relatively similar. Given there is already significant drift and the RuntimeSDK clusterclass is only used for 1 e2e test I don't think it's worth the effort. Nice work! |
Thx 🎉 Don't I already change the mentioned |
@chrischdi Sorry that was the wrong one. I meant
I prefer your current version. Essentially by doing this test with ClusterClass we just have more coverage compared to doing it without ClusterClass. |
/approve Thank you very much!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks a lot @chrischdi for doing this ❤️ |
Thanks a lot.. |
What this PR does / why we need it:
Adds an E2E test for Single Node Cluster (1x control-plane, 0x workers) self-hosted scale-out upgrades.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7230