Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Implement single-node cluster self-hosted upgrade test #7387

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Adds an E2E test for Single Node Cluster (1x control-plane, 0x workers) self-hosted scale-out upgrades.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7230

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2022
@chrischdi chrischdi changed the title 🌱 Implement single-node cluster self-hosted upgrade test 🌱 [WIP] Implement single-node cluster self-hosted upgrade test Oct 11, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2022
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

@chrischdi chrischdi changed the title 🌱 [WIP] Implement single-node cluster self-hosted upgrade test 🌱 Implement single-node cluster self-hosted upgrade test Oct 11, 2022
@fabriziopandini
Copy link
Member

Great to seems multiple efforts coming together so nicely!
/lgtm
I'll defer to @sbueringer and @killianmuldoon to consider if to move also this patch into our runtime extensions (now or in a follow up PR)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@sbueringer
Copy link
Member

sbueringer commented Oct 11, 2022

I'll defer to @sbueringer and @killianmuldoon to consider if to move also this patch into our runtime extensions (now or in a follow up PR)

We could do it and this would require changes to the clusterclass-quick-start.yaml ClusterClass (to add the variable) and to the test extension.

Given that I wouldn't run a test specifically for Runtime SDK + SNC the only benefit would be to keep the two ClusterClasses relatively similar. Given there is already significant drift and the RuntimeSDK clusterclass is only used for 1 e2e test I don't think it's worth the effort.

Nice work!

@chrischdi
Copy link
Member Author

chrischdi commented Oct 11, 2022

I'll defer to @sbueringer and @killianmuldoon to consider if to move also this patch into our runtime extensions (now or in a follow up PR)

We could do it and this would require changes to the clusterclass-quick-start.yaml ClusterClass (to add the variable) and to the test extension.

Given that I wouldn't run a test specifically for Runtime SDK + SNC the only benefit would be to keep the two ClusterClasses relatively similar. Given there is already significant drift and the RuntimeSDK clusterclass is only used for 1 e2e test I don't think it's worth the effort.

Nice work!

Thx 🎉

Don't I already change the mentioned clusterclass-quick-start.yaml anyways?
But also a good point: should we even use clusterclass for this test (this way we could prevent adding the variable)?

@sbueringer
Copy link
Member

@chrischdi Sorry that was the wrong one. I meant clusterclass-quick-start-runtimesdk.yaml.

But also a good point: should we even use clusterclass for this test (this way we could prevent adding the variable)?

I prefer your current version. Essentially by doing this test with ClusterClass we just have more coverage compared to doing it without ClusterClass.

@sbueringer
Copy link
Member

/approve

Thank you very much!!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2ddef5c into kubernetes-sigs:main Oct 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Oct 12, 2022
@Ankitasw
Copy link
Member

Thanks a lot @chrischdi for doing this ❤️

@Vijayakumar0328
Copy link

Thanks a lot..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E for single node clusters with scale out rollout
6 participants