🌱 Add PreCleanupManagementCluster hook to clusterctl upgrade test

[mboukhalfa]

What this PR does / why we need it:
Add hook before cleaning the target management cluster from bootstrap in clusterctl_upgrade.go
This might be needed to run extra steps from certain providers such as moving conflicting services (e.g. DHCP) from target management to bootstrap in the case clusters share the same management LAN.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Hi @mboukhalfa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oscr]

/ok-to-test

[mboukhalfa]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@mboukhalfa: only kubernetes-sigs org members may request cherry-picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/lgtm

/assign @fabriziopandini

[fabriziopandini]

/lgtm
/approve

I don't have any issue in getting this merged, but it seems to me that for some providers it will be easier to write their own clusterctl upgrade test without using nested management clusters as we do in main Cluster API / with CAPD.

Have you considered this (it will probably also speed up test duration, at the cost of requiring a dedicated job for the test)

[mboukhalfa]

/lgtm /approve

I don't have any issue in getting this merged, but it seems to me that for some providers it will be easier to write their own clusterctl upgrade test without using nested management clusters as we do in main Cluster API / with CAPD.

Have you considered this (it will probably also speed up test duration, at the cost of requiring a dedicated job for the test)

Currently metla3 is spinning up bootstrap cluster with an old version and then creates a target cluster with the same version after that it upgrades both to the latest which introduced some complexity I think reusing capi test would be simpler and more reliable to test the target management with checking workload scale up instead of upgrading only the bootstrap or duplicating the same code with some customization.

[mboukhalfa]

/check-cla

[sbueringer]

Hm not sure what's going on with EasyCLA and how to re-trigger it. Maybe a git commit --amend + push --force without changes to force it?

[sbueringer]

Thx!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #7388

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.