✨ Add topology field for MinReadySeconds

[farodin91]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[k8s-ci-robot]

Welcome @farodin91!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @farodin91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[killianmuldoon]

Can you go into a bit of detail on what the goal of this change is? I don't think there's a way to set MinReadySecond in the control plane as it's used in the MachineSet controller - Control Plane Machines are created without a MachineSet.

Would it meet your needs to just set MinReadySeconds in the MachineDeploymentTopology?

[farodin91]

@killianmuldoon I will remove it for control plane. I thought i saw it.

[farodin91]

@killianmuldoon Controlplane changes are removed

[sbueringer]

Thx for this PR. Looks good overall.

Looks like you have to run the following target to re-generate the OpenAPI spec

make generate-go-openapi

[farodin91]

@sbueringer I executed generate go openai, but it didn't work so i copied the patch from the build server.

[sbueringer]

Thx!

/lgtm
(assuming golangci-lint will be green in 2-3 min)

[sbueringer]

/assign @fabriziopandini

[fabriziopandini]

@farodin91 this is a great first contribution, looking forward to see more 😜
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment