Fixed creating clusters in different namespaces when pivoting #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sflxn, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
figo
reviewed
Feb 7, 2019
sflxn
force-pushed
the
fix-namespace-at-pivot
branch
from
db673d8 to
0ead594
Compare
|
lgtm pending outstanding comments. |
There was a bug that prevented pivoting because a desired namespace was specified in the cluster.yaml file. It needs to ensure the the namespace on the target cluster before pivoting. Also, ensuring namespace after getting the target cluster kubeconfig requires a loop with exp backoff in some environments. Fixes kubernetes-sigs#735
sflxn
force-pushed
the
fix-namespace-at-pivot
branch
from
0ead594 to
02260e1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that prevented pivoting because a desired namespace was specified
in the cluster.yaml file. It needs to ensure the the namespace on the target
cluster before pivoting. Also, ensuring namespace after getting the target cluster
kubeconfig requires a loop with exp backoff in some environments.
Fixes #735