Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add ok-to-test label to dependabot prs #7334

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Oct 4, 2022

What this PR does / why we need it:

Felt like unnecessary work to give dependabot "ok-to-test" for each pr. Better to just let it build directly.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Can we get a test PR to ensure that it's working? Maybe on a private repo?

@oscr
Copy link
Contributor Author

oscr commented Oct 4, 2022

@killianmuldoon I can give you something even better: kubernetes-sigs/kubebuilder#2994

@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@fabriziopandini
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

Interesting. This makes me wonder how easily first-time-contributors could circumvent this protection mechanism...

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit c6cbae8 into kubernetes-sigs:main Oct 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants