Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 document migrating to user-managed cert-manager #7290

Merged
merged 1 commit into from
Sep 28, 2022
Merged

📖 document migrating to user-managed cert-manager #7290

merged 1 commit into from
Sep 28, 2022

Conversation

charlie-haley
Copy link
Contributor

What this PR does / why we need it:
Documents migrating from a clusterctl managed cert-manager to user-managed.

Which issue(s) this PR fixes
Fixes #7280

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @charlie-haley!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @charlie-haley. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2022
@charlie-haley charlie-haley changed the title 📝 document migrating to user-managed cert-manager 📖 document migrating to user-managed cert-manager Sep 27, 2022
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@charlie-haley charlie-haley force-pushed the docs/migrating-cert-manager branch from a1f9925 to 7d2eb9d Compare September 27, 2022 12:30
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2022
@charlie-haley charlie-haley force-pushed the docs/migrating-cert-manager branch 2 times, most recently from 9747f32 to 44d41e5 Compare September 27, 2022 12:30
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2022
@charlie-haley charlie-haley requested review from killianmuldoon and removed request for stmcginnis and JoelSpeed September 27, 2022 12:31
killianmuldoon
killianmuldoon approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@sbueringer
Copy link
Member

/lgtm

@fabriziopandini Please don't approve the GitHub actions. I would use this PR to test if the linter is now enforced

/hold
(just for my experiment. I'll drop it once the PR is approved from Fabrizio)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2022
@charlie-haley charlie-haley force-pushed the docs/migrating-cert-manager branch from 44d41e5 to 76a2110 Compare September 28, 2022 16:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@sbueringer
Copy link
Member

Looks good, thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 28, 2022
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@sbueringer
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@sbueringer
Copy link
Member

sbueringer commented Sep 28, 2022 •
edited
Loading

@charlie-haley PR will be merged soon. I just want to take a deep-dive into the Prow merge-bot to figure out why it doesn't behave as expected. I'll merge afterwards

@charlie-haley
Copy link
Contributor Author

No rush, thanks @sbueringer

fabriziopandini
fabriziopandini reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

@fabriziopandini Please don't remove the hold. Debugging tide..

@sbueringer
Copy link
Member

Okay after debugging through tide.

The PR should not be merged. It's just that the missing linter is not shown in the Tide UI

/hold cancel

PR should now be stuck as the lint context is not successful even though it's required. Let's see what happens

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3dc581b into kubernetes-sigs:main Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 28, 2022
@sbueringer
Copy link
Member

(allowed the linters, so everything behaving as expected now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

document migrating to user-managed cert-manager
5 participants
@charlie-haley @k8s-ci-robot @sbueringer @fabriziopandini @killianmuldoon