-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Improve provider definition in the glossary #7260
📖 Improve provider definition in the glossary #7260
Conversation
/hold |
/hold cancel |
799fef6
to
45c9581
Compare
made a pass on the book ensuring terms are used consistently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits, otherwise lgtm
lgtm pending squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes IMO.
Just a bunch of nits and rewordings in my review, none of them blocking.
defd875
to
89e538a
Compare
89e538a
to
0ce477c
Compare
Thx! |
0ce477c
to
c6ae009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@fabriziopandini Should we merge or do we want to wait a bit longer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
@sbueringer: new pull request created: #7326 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR updates the definition of provider in the glossary to include all the components that can be deployed and provides a functionality to the Cluster API management Cluster.
This acknowledges the fact that we are already using this term for many things including core provider, infra provider, bootstrap and CP providers, and makes this suitable for including IPAM providers, Cluster add-on providers, Runtime Extension providers (which is a new term being defined in the Runtime SDK proposal).
If this is accepted, this will allow us to benefit of all the clusterctl machinery and provide a consistent UX for the users