Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Improve provider definition in the glossary #7260

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

This PR updates the definition of provider in the glossary to include all the components that can be deployed and provides a functionality to the Cluster API management Cluster.

This acknowledges the fact that we are already using this term for many things including core provider, infra provider, bootstrap and CP providers, and makes this suitable for including IPAM providers, Cluster add-on providers, Runtime Extension providers (which is a new term being defined in the Runtime SDK proposal).

If this is accepted, this will allow us to benefit of all the clusterctl machinery and provide a consistent UX for the users

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2022
@fabriziopandini
Copy link
Member Author

/hold
for office hours discussion

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022
@fabriziopandini
Copy link
Member Author

/hold cancel
from the office hours discussion It seems there is a general consensus about the idea
I'm going to check the book to make sure we are using updated terms consistently, and finally remove wip

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2022
@fabriziopandini fabriziopandini force-pushed the improve-provider-definition branch from 799fef6 to 45c9581 Compare September 23, 2022 12:29
@fabriziopandini fabriziopandini changed the title [WIP] 📖 Improve provider definition in the glossary 📖 Improve provider definition in the glossary Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 23, 2022
@fabriziopandini
Copy link
Member Author

made a pass on the book ensuring terms are used consistently
now this PR is ready for review

Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, otherwise lgtm

docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

lgtm pending squash

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes IMO.

Just a bunch of nits and rewordings in my review, none of them blocking.

docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the improve-provider-definition branch from defd875 to 89e538a Compare September 27, 2022 14:41
@fabriziopandini fabriziopandini force-pushed the improve-provider-definition branch from 89e538a to 0ce477c Compare September 28, 2022 11:41
@sbueringer
Copy link
Member

Thx!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
docs/book/src/reference/glossary.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the improve-provider-definition branch from 0ce477c to c6ae009 Compare September 29, 2022 18:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@sbueringer
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

@fabriziopandini Should we merge or do we want to wait a bit longer?

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4858704 into kubernetes-sigs:main Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 30, 2022
@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #7326

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the improve-provider-definition branch October 10, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants