Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 ClusterClass: relax validation of MD variables overrides of opt variables #7243

Merged
merged 1 commit into from
Sep 27, 2022
Merged

🌱 ClusterClass: relax validation of MD variables overrides of opt variables #7243

merged 1 commit into from
Sep 27, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 19, 2022 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

I tested roughly:

  • initially variable: required + Cluster: set on MD + set on top-level
  • Cluster tried to unset top-level => validation error
  • made variable optional > could set/remove it on MD and top-level arbitrarily
  • tried to make variable required again > only worked after the top-level variable was set again

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2022
@sbueringer sbueringer changed the title 🌱 ClusterClass: relax validation of MD variables overrides of opt 🌱 ClusterClass: relax validation of MD variables overrides of opt variables Sep 19, 2022
@sbueringer
Copy link
Member Author

cc @fabriziopandini

@fabriziopandini
Copy link
Member

/lgtm

@killianmuldoon PTAL when you have some time

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2022
killianmuldoon
killianmuldoon reviewed Sep 27, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

/lgtm

@sbueringer
Copy link
Member Author

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1b7490a into kubernetes-sigs:main Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 27, 2022
@sbueringer sbueringer deleted the pr-relax-md-var-validation branch September 27, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Relax validation for MachineDeployment's variables.overrides
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon