-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Use Kubernetes 1.25 in Quick Start docs and CAPD. #7156
⚠️ Use Kubernetes 1.25 in Quick Start docs and CAPD. #7156
Conversation
/test pull-cluster-api-e2e-informing-main |
9da40de
to
bd36b96
Compare
/test ? |
This comment was marked as outdated.
This comment was marked as outdated.
/test pull-cluster-api-e2e-full-main |
248ee40
to
80e49ff
Compare
lgtm pending full tests /test pull-cluster-api-e2e-full-main |
After merge we should do a manual cherry-pick PR against release-1.2 with the following delta:
Just to avoid bumping a dependency to another minor version in a CAPI patch release |
Since the default image has changed between 0.14 and 0.15, do you mean explicitly setting the image when creating clusters? For example by adding |
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125 I suspect we need to look at this. I will see what I can do. |
Should be fine our test framework sets the image when it creates the mgmt cluster programmatically: cluster-api/test/e2e/e2e_suite_test.go Lines 219 to 226 in 831d67f
(based on docker.yaml KUBERNETES_VERSION_MANAGEMENT) |
89f4d62
to
cfbde71
Compare
/test pull-cluster-api-e2e-full-main |
cfbde71
to
57341ad
Compare
57341ad
to
31177fd
Compare
31177fd
to
72259a5
Compare
/test pull-cluster-api-e2e-full-main |
/test pull-cluster-api-e2e-full-main |
Thank you very much!! /lgtm /assign @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only small nit :-) lgtm except that 👍
Great work 🎉
Use kind 0.15.0 and Calico 3.24.1 in the Quick Start.
72259a5
to
5196df5
Compare
/test pull-cluster-api-e2e-full-main |
/lgtm |
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main |
1 similar comment
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, thanks for taking care of this task!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updates the Quick Start guide to use Kubernetes 1.25. Now using kind 0.15.0 and Calico 3.24.1.
Calico was updated due to breakage
error: unable to recognize "https://docs.projectcalico.org/v3.21/manifests/calico.yaml": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
.The updated QS "works on my machine" and all pods in management and worker cluster seem to be running.
Part of #6661