Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel rules-go #714

Merged

Conversation

justinsb
Copy link
Contributor

We need the latest rules-go to build with go 1.11.5 (unless we want to
map it manually).

NONE

We need the latest rules-go to build with go 1.11.5 (unless we want to
map it manually).
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit ad8c7f3 into kubernetes-sigs:master Jan 26, 2019
enxebre pushed a commit to enxebre/cluster-api that referenced this pull request Jan 30, 2019
We need the latest rules-go to build with go 1.11.5 (unless we want to
map it manually).
openshift-merge-robot pushed a commit to openshift/cluster-api that referenced this pull request Jan 30, 2019
We need the latest rules-go to build with go 1.11.5 (unless we want to
map it manually).
paulfantom pushed a commit to openshift/cluster-api that referenced this pull request Feb 21, 2019
We need the latest rules-go to build with go 1.11.5 (unless we want to
map it manually).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants