🌱 Add test-extension patch artifacts to git ignore #7137
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
killianmuldoon
changed the title
k8s-ci-robot
added
the
size/XS
| test/e2e/data/test-extension/deployment.yaml | ||
| test/extension/config/default/extension_image_patch.yaml-e | ||
| test/extension/config/default/extension_pull_policy.yaml-e | ||
|
|
There was a problem hiding this comment.
Just to clarify those files are not generated. They are some side-effect of afaik an editor (or maybe something else?).
I also have them from time to time, but only very rarely (and up until now I only had them for the files which are overwritten when running make docker-build, e.g. config/default/manager_image_patch.yaml)
Or?
There was a problem hiding this comment.
Given the way we change those files I would guess some tmp files of sed
Just a random finding on stackoverflow, but maybe there's a way to fix our sed calls that those files never occur
There was a problem hiding this comment.
I was trying to track down what created them - I assume it's either kustomize or intellij, but I still haven't figured it out 🙁.
Good to have them in the .gitignore anyway IMO - also have them for the manager*.yaml-e already.
There was a problem hiding this comment.
Good find! This seems to be an OSX issue, and I think it's well enough taken care of by adding it to gitignore. Might be a good idea for me to add gnu sed to my env though!
There was a problem hiding this comment.
I'm fine with just adding them, let's just do it for all (as you suggested) and let's add a short comment where those files are ~ coming from.
This should only affect ~ two files per manager which should be the ones we run sed / that make target on
There was a problem hiding this comment.
How does the latest version look?
There was a problem hiding this comment.
Confirmed btw that gnu-sed on MacOS doesn't have this issue. Our flags for sed aren't fully portable. I'll create an issue for that to track it, but it's low impact and priority imo
There was a problem hiding this comment.
How does the latest version look?
Perfect. I didn't know we already had the gitignore for manager YAMLs. But explains why you're only seeing that issue now
killianmuldoon
force-pushed
the
gitignore/add-test-extension
branch
from
55e0436 to
9ea5cb5
Compare
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
gitignore/add-test-extension
branch
from
9ea5cb5 to
f2aabd2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: killianmuldoon [email protected]
Add the yaml-e files generated with the test extension to the .gitignore.