-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade golang version (1.18.3 -> 1.19.0) #7135
Conversation
@oscr Can you please also update the go version in v.12-to-v1.3.md? (I'll re-run the presubmits once the last finding on the test-infra PR is fixed and the test-infra PR is merged) |
cb18bb1
to
2fb25ef
Compare
@sbueringer Done. I didn't bump |
I think it's fine when we bump it when we actually bump our Go dependencies in #7123 (or as a follow-up to that one) |
/retest |
/lgtm Looks like the jobs are working now |
Great Job! for a last check |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Upgrade golang version 1.18.3 -> 1.19.0 as required by v1.25.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #6661