🌱 Update golangci-lint to 1.49.0 #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
lint/update-1.49
branch
from
8a8f7d7 to
63b176b
Compare
k8s-ci-robot
added
size/M
killianmuldoon
commented
Aug 24, 2022
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
lint/update-1.49
branch
from
9172b86 to
3b91a63
Compare
|
/hold Until #7115 is decided. |
k8s-ci-robot
added
the
do-not-merge/hold
killianmuldoon
commented
Aug 24, 2022
sbueringer
reviewed
Aug 24, 2022
killianmuldoon
force-pushed
the
lint/update-1.49
branch
3 times, most recently
from
2612f34 to
d0ec8f6
Compare
|
I squashed the commits so this sing commit now contains the removal of deprecated linters. |
killianmuldoon
force-pushed
the
lint/update-1.49
branch
from
d0ec8f6 to
76c0e62
Compare
sbueringer
reviewed
Aug 24, 2022
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
lint/update-1.49
branch
from
76c0e62 to
b9509d0
Compare
|
/retest |
|
Thx! |
k8s-ci-robot
added
the
lgtm
oscr
reviewed
Aug 24, 2022
| - linters: | ||
| - ifshort | ||
| text: "variable 'kcpMachinesWithErrors' is only used in the if-statement.*" | ||
| path: ^controlplane/kubeadm/internal/workload_cluster_conditions\.go$ | ||
| # We don't care about defer in for loops in test files. | ||
| - linters: | ||
| - gocritic |
There was a problem hiding this comment.
There was a problem hiding this comment.
For reference: addressed in: https://github.com/kubernetes-sigs/cluster-api/pull/7122/files
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
Update golangci-lint to version 1.49. This update re-enables the revive rules that were disabled in v1.48.0