-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add release team process #7110
📖 Add release team process #7110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this looks great, thanks for putting it together @CecileRobertMichon =)
i have a question about the team selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write-up, learned a lot about the release team/process from the document 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CecileRobertMichon thanks for driving this!
e7cdba6
to
34f1d9a
Compare
Addressed all comments, thanks for all the reviews! |
It's probably worth to reference this here https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#finding-things-that-need-help |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Just had a couple of questions and a nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for driving this. Overall lgtm, just some ideas/suggestions
34f1d9a
to
3071cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -51,7 +51,7 @@ come up, including gaps in documentation! | |||
|
|||
If you're a more experienced contributor, looking at unassigned issues in the next release milestone is a good way to find work that has been prioritized. For example, if the latest minor release is `v1.0`, the next release milestone is `v1.1`. | |||
|
|||
Help and contributions are very welcome in the form of code contributions but also in helping to moderate office hours, triaging issues, fixing/investigating flaky tests, cutting releases, helping new contributors with their questions, reviewing proposals, etc. | |||
Help and contributions are very welcome in the form of code contributions but also in helping to moderate office hours, triaging issues, fixing/investigating flaky tests, being part of the [release team](docs/developer/release-team.md), helping new contributors with their questions, reviewing proposals, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the link leads to a 404 in the book. (https://deploy-preview-7110--kubernetes-sigs-cluster-api.netlify.app/docs/developer/release-team.html)
I think this can be fixed either by moving the relase-team doc into the book or by changing the link to an absolute link (after merge)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be fixed either by moving the relase-team doc into the book
even if I move it there is no way to make the link for both the book and the CONTRIBUTING.md file outside the book right? because if it's developer/release-team.md
in the book that same link won't work in the repo tree.
If so the only way is to change it to an absolute link, which I can do after merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a custom 404 page to netlify that redirects from docs/<path>
to <path>
? Then those links would work on both sites.
Edit: can even be done with netlify config: https://docs.netlify.com/routing/redirects/redirect-options/#splats
Edit # 2: Nevermind :D
lgtm pending #7110 (comment) |
thanks for all the hard work everybody, and @CecileRobertMichon for driving this forward. it's generally LGTM to me. |
Thx @CecileRobertMichon ! /lgtm |
/assign @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @CecileRobertMichon!!
/lgtm
Let's get this rolling! Next step define the first Release team and the next release date! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
@sbueringer: new pull request created: #7145 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it: As discussed in office hours and in #6442, this document introduces the concept of a CAPI release team. Note that this document is intended to be a starting point for the release team. It is not a complete release process document.
Most of this proposal comes from the discussions in https://docs.google.com/document/d/1DQIsu2nLvkPD5x4c0GW7oYZjb1PUINv4mGPzB_PmPws/edit#. Kudos to @LappleApple for starting it.
A lot of this process is inspired from https://github.com/kubernetes/sig-release/blob/master/release-team/README.md, credits go to the Kubernetes release SIG and past release teams for making it a great resource.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #