Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add release team process #7110

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Aug 23, 2022

What this PR does / why we need it: As discussed in office hours and in #6442, this document introduces the concept of a CAPI release team. Note that this document is intended to be a starting point for the release team. It is not a complete release process document.

Most of this proposal comes from the discussions in https://docs.google.com/document/d/1DQIsu2nLvkPD5x4c0GW7oYZjb1PUINv4mGPzB_PmPws/edit#. Kudos to @LappleApple for starting it.

A lot of this process is inspired from https://github.com/kubernetes/sig-release/blob/master/release-team/README.md, credits go to the Kubernetes release SIG and past release teams for making it a great resource.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2022
@CecileRobertMichon
Copy link
Contributor Author

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this looks great, thanks for putting it together @CecileRobertMichon =)

i have a question about the team selection.

docs/developer/release-team.md Show resolved Hide resolved
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up, learned a lot about the release team/process from the document 💯

docs/developer/release-team.md Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 🚀

docs/developer/release-team.md Show resolved Hide resolved
docs/developer/release-team.md Outdated Show resolved Hide resolved
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecileRobertMichon thanks for driving this!

docs/developer/release-team.md Outdated Show resolved Hide resolved
docs/developer/release-team.md Outdated Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
@CecileRobertMichon CecileRobertMichon changed the title [WIP] 📖 Add release team process 📖 Add release team process Aug 26, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2022
@CecileRobertMichon
Copy link
Contributor Author

Addressed all comments, thanks for all the reviews!

@enxebre
Copy link
Member

enxebre commented Aug 29, 2022

It's probably worth to reference this here https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#finding-things-that-need-help
Thanks Cecile!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
@fabriziopandini
Copy link
Member

/lgtm

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Just had a couple of questions and a nit.

docs/developer/release-team.md Outdated Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for driving this. Overall lgtm, just some ideas/suggestions

docs/developer/release-team.md Outdated Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
docs/developer/release-team.md Outdated Show resolved Hide resolved
docs/developer/release-team.md Show resolved Hide resolved
docs/developer/release-team.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
@CecileRobertMichon CecileRobertMichon self-assigned this Aug 29, 2022
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
@@ -51,7 +51,7 @@ come up, including gaps in documentation!

If you're a more experienced contributor, looking at unassigned issues in the next release milestone is a good way to find work that has been prioritized. For example, if the latest minor release is `v1.0`, the next release milestone is `v1.1`.

Help and contributions are very welcome in the form of code contributions but also in helping to moderate office hours, triaging issues, fixing/investigating flaky tests, cutting releases, helping new contributors with their questions, reviewing proposals, etc.
Help and contributions are very welcome in the form of code contributions but also in helping to moderate office hours, triaging issues, fixing/investigating flaky tests, being part of the [release team](docs/developer/release-team.md), helping new contributors with their questions, reviewing proposals, etc.
Copy link
Member

@sbueringer sbueringer Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the link leads to a 404 in the book. (https://deploy-preview-7110--kubernetes-sigs-cluster-api.netlify.app/docs/developer/release-team.html)

I think this can be fixed either by moving the relase-team doc into the book or by changing the link to an absolute link (after merge)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be fixed either by moving the relase-team doc into the book

even if I move it there is no way to make the link for both the book and the CONTRIBUTING.md file outside the book right? because if it's developer/release-team.md in the book that same link won't work in the repo tree.

If so the only way is to change it to an absolute link, which I can do after merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

Copy link
Member

@schrej schrej Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom 404 page to netlify that redirects from docs/<path> to <path>? Then those links would work on both sites.

Edit: can even be done with netlify config: https://docs.netlify.com/routing/redirects/redirect-options/#splats
Edit # 2: Nevermind :D

@sbueringer
Copy link
Member

lgtm pending #7110 (comment)

@elmiko
Copy link
Contributor

elmiko commented Aug 30, 2022

thanks for all the hard work everybody, and @CecileRobertMichon for driving this forward. it's generally LGTM to me.

@sbueringer
Copy link
Member

Thx @CecileRobertMichon !

/lgtm

@CecileRobertMichon
Copy link
Contributor Author

/assign @fabriziopandini

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @CecileRobertMichon!!

/lgtm

@fabriziopandini
Copy link
Member

Let's get this rolling! Next step define the first Release team and the next release date!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit fbbea76 into kubernetes-sigs:main Sep 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 1, 2022
@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #7145

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.