Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 📖 Add example queries to developer logging guidelines #7084

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[release-1.2] 📖 Add example queries to developer logging guidelines #7084

merged 1 commit into from
Aug 18, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #7015

/assign sbueringer

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 18, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2022
killianmuldoon
killianmuldoon approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2022
neolit123
neolit123 reviewed Aug 18, 2022
View reviewed changes
docs/book/src/developer/logging.md
@@ -161,9 +163,43 @@ extra_args:
- "--v=5"
- "--logging-format=json"
```
The above options can be combined with other settings from our [Tilt](tilt.md) setup. Once Tilt is is up and running with these settings users will be able to browse logs using the Grafana Explore UI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double 'is'

Copy link
Member

@sbueringer sbueringer Aug 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Good finding

Given that this is a cherry-pick we should fix the typo on main first and then cherry-pick that fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7085

@sbueringer
Copy link
Member

sbueringer commented Aug 18, 2022 •
edited
Loading

/approve

@killianmuldoon When you've got a few minutes. Can you open a fix PR for main for the finding above? Thank you very much!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@killianmuldoon killianmuldoon mentioned this pull request Aug 18, 2022
Merged
@k8s-ci-robot k8s-ci-robot merged commit 34fc549 into kubernetes-sigs:release-1.2 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@neolit123 neolit123 neolit123 left review comments

@sbueringer sbueringer Awaiting requested review from sbueringer

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @sbueringer @neolit123 @killianmuldoon