-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 kubebuilder: switch back to darwin arm64 binaries #7080
🌱 kubebuilder: switch back to darwin arm64 binaries #7080
Conversation
Signed-off-by: Stefan Büringer [email protected]
@sbueringer: This issue is currently awaiting triage. If CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Needs verification from some arm-people @mboersma @chrischdi IIRC. Would be good if one of you can run the tests locally to confirm that the arm binaries work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Running tests fine using the arm binary after I cleaned up the old install.
Works on my Mac M1 👍 /lgtm |
Thx @killianmuldoon @chrischdi! Didn't really remember who is on which architecture :D /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Just saw that it should be fixed with recent kubebuilder releases
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #