-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] 📖 Update docs/Makefile. Fix proposal diagrams transparency #7050
[release-1.2] 📖 Update docs/Makefile. Fix proposal diagrams transparency #7050
Conversation
@oscr: This issue is currently awaiting triage. If CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine with adding the 2 cherry-picks to this PR given that they are related.
Let's make sure to update the PR description to clearly call out that it is a manual cherry pick for the 2 PRs and also let's update the title of the PR to reflect the changes (important when generating the release catalog).
Regenerate CAPI book diagrams with new version to ensure consistent look and feel.
22a3313
to
7854dd9
Compare
I also included #7017 to keep the build working. With it |
@ykakarap I updated the pr description to reflect the changes as you mentioned. Anything you would like to add? |
One thing 🙂 |
That just brings the title into line with how we tend to do other cherry-picks |
One thing 🙂 |
Is there a reason why we can't cherry-pick the individual PRs in the right order? It would save us the work of re-reviewing all changes and would keep it a lot simpler tracking-wise |
Diffed against main. Everything identical apart from #7056 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds 3 pr's that updates the CAPI book and proposals diagrams and the Makefile.