🌱 Improve logging for the MachineSet scale up/down workflow #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
12 tasks
fabriziopandini
force-pushed
the
improve-machineset-scale-up-down-logs
branch
2 times, most recently
from
51c0d95 to
aba29f8
Compare
sbueringer
reviewed
Aug 19, 2022
k8s-ci-robot
added
the
needs-rebase
fabriziopandini
force-pushed
the
improve-machineset-scale-up-down-logs
branch
from
aba29f8 to
b6fddfd
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@sbueringer all the comments should be addressed now, PTAL at your convenience |
fabriziopandini
force-pushed
the
improve-machineset-scale-up-down-logs
branch
from
b6fddfd to
d108d42
Compare
sbueringer
reviewed
Sep 2, 2022
|
@sbueringer comments addressed; changes are in a separated commit for a faster review |
|
Thx! /approve lgtm pending squash :) |
k8s-ci-robot
added
the
approved
|
/approve cancel Hm maybe let's not approve already, not that it gets accidentally merged before squash :) |
k8s-ci-robot
removed
the
approved
fabriziopandini
force-pushed
the
improve-machineset-scale-up-down-logs
branch
from
11cd71d to
6eda8ea
Compare
|
@sbueringer squashed |
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make logs for the MachineSet scale up/down workflow consistent with the new logging guidelines
Which issue(s) this PR fixes:
Rif #6994