🌱 improve logging for the machine provisioning workflow #6993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
12 tasks
fabriziopandini
force-pushed
the
improve-machine-provisioning-logs
branch
2 times, most recently
from
dbb6218 to
263ba79
Compare
There was a problem hiding this comment.
Currently I'm getting requeueing in multiple log messages which is confusing.
Waiting for bootstrap provider to generate data secret and report status.ready, requeing
Waiting for infrastructure provider to create machine infrastructure and report status.ready, requeing
Waiting for infrastructure provider to report spec.providerID
This is because even though we return requeueAfter we end each of the phase functions (and logging their results).
Could we instead log the result, or some "ending reconcile" message after (maybe) LowestNonZeroResult?
fabriziopandini
force-pushed
the
improve-machine-provisioning-logs
branch
from
263ba79 to
db1169e
Compare
|
I have dropped requeueing entirely, it doesn't add much value on top of Waiting |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improve machine provisioning logging based on project's logging guidelines introduced by #6969