🐛 Add OwnerRef to clusterResourceSetBinding on each reconcile #6989
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
killianmuldoon
changed the title
k8s-ci-robot
added
the
size/S
| @@ -264,6 +264,9 @@ func (r *ClusterResourceSetReconciler) ApplyClusterResourceSet(ctx context.Conte | |||
| } | |||
| }() | |||
|
|
|||
| // Ensure that the owner references are set on the ClusterResourceSetBinding. | |||
| clusterResourceSetBinding.OwnerReferences = ensureOwnerRefs(clusterResourceSetBinding, clusterResourceSet, cluster) | |||
There was a problem hiding this comment.
Note this is done in the ClusterResourceSet reconcile rather than the ClusterResourceSetBinding reconcile. This may cause some slight drift in setting the owner references.
The main case we care about is backup -> restore -> deletion so the drift of a couple of minutes should be acceptable. In the normal case we'd expect these owner references to be applied on the first reconcile of the ClusterResourceSet i.e. right after restore + unpause.
|
/kind bug |
k8s-ci-robot
added
kind/bug
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
fix/clusterresourcesetbinding-ownerref
branch
from
4f4e23d to
73cacfd
Compare
k8s-ci-robot
added
size/M
killianmuldoon
changed the title
| @@ -100,6 +100,14 @@ func (c *ClusterResourceSetBinding) DeleteBinding(clusterResourceSet *ClusterRes | |||
| break | |||
| } | |||
| } | |||
| // Remove the ClusterResourceSet from the ClusterResourceSetBinding OwnerReferences. | |||
| for i, ownerRef := range c.OwnerReferences { | |||
There was a problem hiding this comment.
Previously we weren't updating ownerReferences at all after creation so the initial ClusterResourceSet was always an owner even if it had been deleted.
|
overall lgtm, thanks for tackling this |
killianmuldoon
force-pushed
the
fix/clusterresourcesetbinding-ownerref
branch
from
73cacfd to
8737a55
Compare
|
/cherry-pick release-1.2 |
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
killianmuldoon
force-pushed
the
fix/clusterresourcesetbinding-ownerref
branch
from
8737a55 to
96c71f5
Compare
k8s-ci-robot
added
the
lgtm
killianmuldoon
force-pushed
the
fix/clusterresourcesetbinding-ownerref
branch
from
96c71f5 to
f152444
Compare
k8s-ci-robot
removed
the
lgtm
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
fix/clusterresourcesetbinding-ownerref
branch
from
f152444 to
daf21c0
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@vincepri: new pull request created: #7012 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
Fix an issue where OwnerReferences were only added to a ClusterResourceSetBinding on Create. This fix will ensure the references are set each time the ClusterResourceSet the Binding is created from from is reconciled.
Fixes #6007