-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 improve templates ui in tilt #6984
🌱 improve templates ui in tilt #6984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements.
Some cosmetic improvements:
-
Now because the same cluster name is reused, unless changed by the user, the yaml created will keep modifying the same cluster over and over again. It would be nice to rename some of the button and logs to become "applying cluster " instead of "creating cluster " to avoid any confusion.
-
Similarly the button
"Delete" + template_name + "clusters"
wont behave the same way as the cluster names no longer follow a predicable pattern. It would be nice to also add a text-input to theDelete button
so that one can delete a target cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement 👍 Already thought about that too.
/lgtm
@fabriziopandini This change looks great! In For example, if you set
I opened #6968 to fix it, but do you think you could add this change here? |
@Jont828 @ykakarap PTAL |
3925d72
to
0f12635
Compare
0f12635
to
804ffc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for making this change! |
What this PR does / why we need it:
Small improvements in templates UI in tilt: