Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add ControlPlaneWaiters to input for e2e specs #6964

Merged

Conversation

CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: Enable configuring ControlPlaneWaiters for all e2e test specs where it's relevant (all except kcp adoption) to allow infra providers running the CAPI test suite with different Control Plane providers and/or custom waiters to leverage those.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 20, 2022
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit and a question

test/e2e/node_drain_timeout.go Outdated Show resolved Hide resolved
test/e2e/self_hosted.go Outdated Show resolved Hide resolved
@CecileRobertMichon CecileRobertMichon force-pushed the controlplanewaiters-e2e branch from c99dbec to d43ad97 Compare July 21, 2022 23:24
@CecileRobertMichon CecileRobertMichon force-pushed the controlplanewaiters-e2e branch from d43ad97 to 7e8eec1 Compare July 21, 2022 23:28
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2022
@CecileRobertMichon
Copy link
Contributor Author

/assign @fabriziopandini

@CecileRobertMichon
Copy link
Contributor Author

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit bc177c6 into kubernetes-sigs:main Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 25, 2022
@k8s-infra-cherrypick-robot

@CecileRobertMichon: new pull request created: #6978

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants