🌱 Update example version of core CAPI used in clusterctl #6937
Conversation
Signed-off-by: killianmuldoon <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
killianmuldoon
changed the title
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
| @@ -30,18 +30,18 @@ type DeleteOptions struct { | |||
| // default rules for kubeconfig discovery will be used. | |||
| Kubeconfig Kubeconfig | |||
|
|
|||
| // CoreProvider version (e.g. cluster-api:v0.3.0) to add to the management cluster. If unspecified, the | |||
| // CoreProvider version (e.g. cluster-api:v1.1.5) to add to the management cluster. If unspecified, the | |||
There was a problem hiding this comment.
I went for this as 1.1.5 is released, recent and stable - I don't think we need the most recent versions possible in these examples (but more recent than 0.3.0 would be nice 🙂
|
What is the benefit of trying to keep those versions up-to-date? |
I don't think we should be overly zealous about these versions, but something more recent than completely unsupported is probably reasonable. I think these examples are a signal for users and could possibly be used for copy-paste etc. by new users. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: killianmuldoon [email protected]
Update the version of CAPI used in examples across the clusterctl codebase.