[release-1.2] 📖 add note ClusterClass compatibility info to validating webhooks section #6909
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
| @@ -35,4 +57,4 @@ type Cluster struct { | |||
| A detailed guide on the purpose of each of these tags is [here](https://book.kubebuilder.io/reference/markers/webhook.html). | |||
|
|
|||
| <!-- links --> | |||
| [the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.1/internal/webhooks/cluster.go | |||
| [the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/webhooks/cluster.go | |||
There was a problem hiding this comment.
| [the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/webhooks/cluster.go | |
| [the Cluster webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.2/internal/webhooks/cluster.go |
cc @sbueringer
There was a problem hiding this comment.
Should this be 1.2?
There was a problem hiding this comment.
If we drop it here it will never end up in a published book.
I'm not sure how important it is to always point to the book to the corresponding version of the code. Seems like too much effort to maintain the correct mapping to be honest
There was a problem hiding this comment.
Just missed that the current link points to release-1.1. Can someone open a follow-up PR (against main) to change that link to main as well?
| See [the DockerMachineTemplate webhook] as a reference for a compatible implementation. | ||
|
|
||
| [Server Side Apply]: https://kubernetes.io/docs/reference/using-api/server-side-apply/ | ||
| [the DockerMachineTemplate webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/test/infrastructure/docker/api/v1beta1/dockermachinetemplate_webhook.go |
There was a problem hiding this comment.
| [the DockerMachineTemplate webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/main/test/infrastructure/docker/api/v1beta1/dockermachinetemplate_webhook.go | |
| [the DockerMachineTemplate webhook]: https://github.com/kubernetes-sigs/cluster-api/blob/release-1.2/test/infrastructure/docker/api/v1beta1/dockermachinetemplate_webhook.go |
Maybe?
There was a problem hiding this comment.
Yeah - I think that's right
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Let's keep this on main for now, We can eventually iterate to make book maintenance simpler |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is an automated cherry-pick of #6875
/assign sbueringer