Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 SSA: improve comment about metadata.uid #6893

Merged
merged 1 commit into from
Jul 13, 2022
Merged

🌱 SSA: improve comment about metadata.uid #6893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions internal/controllers/topology/cluster/structuredmerge/serversidepathhelper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,13 @@ func NewServerSidePatchHelper(ctx context.Context, original, modified client.Obj
filterObject(modifiedUnstructured, helperOptions)

// Carry over uid to match the intent to:
// * create (uid==""): Setting no uid ensures an object gets created, not updated.
// * update (uid!=""): Setting an uid ensures an object which has the same uid gets updated.
// * create (uid==""):
// * if object doesn't exist => create
// * if object already exists => update
sbueringer marked this conversation as resolved.
Show resolved Hide resolved
// * update (uid!=""):
// * if object doesn't exist => fail
// * if object already exists => update
// * This allows us to enforce that an update doesn't create an object which has been deleted.
modifiedUnstructured.SetUID("")
if originalUnstructured != nil {
modifiedUnstructured.SetUID(originalUnstructured.GetUID())
Expand Down