Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test/e2e stream runtime SDK extension controller logs to artifacts #6892

Merged
merged 1 commit into from
Jul 12, 2022
Merged

🌱 test/e2e stream runtime SDK extension controller logs to artifacts #6892

merged 1 commit into from
Jul 12, 2022

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Waits for the test extension deployment to be running and streams logs of it for being able to debug issues via test extension logs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot requested a review from JoelSpeed July 11, 2022 13:41
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot requested a review from stmcginnis July 11, 2022 13:41
@chrischdi chrischdi force-pushed the pr-runtime-sdk-stream-ext-logs branch from 8ea19e7 to 7943014 Compare July 11, 2022 13:49
@chrischdi
Copy link
Member Author

/test all

@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

@chrischdi chrischdi force-pushed the pr-runtime-sdk-stream-ext-logs branch from 7943014 to 9597483 Compare July 11, 2022 14:00
@chrischdi
Copy link
Member Author

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

@chrischdi chrischdi force-pushed the pr-runtime-sdk-stream-ext-logs branch from 9597483 to be12bed Compare July 11, 2022 14:04
@chrischdi
Copy link
Member Author

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/retitle 🌱 test/e2e stream runtime SDK extension controller logs to artifacts

@k8s-ci-robot k8s-ci-robot changed the title 🌱 [wip] test/e2e stream runtime SDK extension controller logs to artifacts 🌱 test/e2e stream runtime SDK extension controller logs to artifacts Jul 11, 2022
killianmuldoon
killianmuldoon reviewed Jul 11, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. I've got it up and running for the runtimeSDK tests and it's all working.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@chrischdi chrischdi force-pushed the pr-runtime-sdk-stream-ext-logs branch from be12bed to dca7aaa Compare July 11, 2022 16:42
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
sbueringer
sbueringer reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@chrischdi chrischdi force-pushed the pr-runtime-sdk-stream-ext-logs branch from dca7aaa to 7b93c34 Compare July 12, 2022 06:20
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@chrischdi
Copy link
Member Author

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main

@chrischdi
Copy link
Member Author

Seems to look good :-)

https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/6892/pull-cluster-api-e2e-informing-main/1546741606663589888/artifacts/clusters/bootstrap/logs/k8s-upgrade-with-runtimesdk-8cfkna/test-extension/test-extension-59d58768d8-tlf69/

@sbueringer
Copy link
Member

/lgtm

Would be good if you can create a follow-up issue for #6892 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2022
@chrischdi chrischdi mentioned this pull request Jul 12, 2022
Closed
@chrischdi
Copy link
Member Author

/lgtm

Would be good if you can create a follow-up issue for #6892 (comment)

done: #6900

@fabriziopandini
Copy link
Member

/lgtm
/approve

/cherry-pick release-1.2
This is a valuable addition for our test signal.

I suggest also opening a follow-up issue so we can search for deployments with a well know label instead of relying on a well-known name. This will make the test helper usable by projects having different extensions names or for use cases where more than one extension is required

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-1.2
This is a valuable addition for our test signal.

I suggest also opening a follow-up issue so we can search for deployments with a well know label instead of relying on a well-known name. This will make the test helper usable by projects having different extensions names or for use cases where more than one extension is required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0f2f85c into kubernetes-sigs:main Jul 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 12, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 12, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #6902

In response to this:

/lgtm
/approve

/cherry-pick release-1.2
This is a valuable addition for our test signal.

I suggest also opening a follow-up issue so we can search for deployments with a well know label instead of relying on a well-known name. This will make the test helper usable by projects having different extensions names or for use cases where more than one extension is required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi chrischdi mentioned this pull request Jul 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@chrischdi @k8s-ci-robot @sbueringer @fabriziopandini @k8s-infra-cherrypick-robot @killianmuldoon