-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Split MD link checker into periodic and PR focused #6853
🌱 Split MD link checker into periodic and PR focused #6853
Conversation
on: | ||
schedule: | ||
- cron: "0 9 * * 1" | ||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need branches here, but I'm not sure if this will actually scan every branch on the repo (that could be a good thing to pick up broken links in older versions of the book)
09791bf
to
c9bfb40
Compare
/hold Still figuring out the right syntax for the cronjob. |
e75fdeb
to
ffd080d
Compare
/remove-hold This should run weekly on a Thursday once merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Great idea 👍
How do we get notified for a failing weekly gh action? Normally we track this via testgrid which is obviously not possible using gh actions I think?!
I think we'll get a notification (if you have failing actions turned on in github notifications) |
Yup we should. |
Signed-off-by: killianmuldoon <[email protected]>
ffd080d
to
9ef2afd
Compare
/lgtm /cherry-pick release-1.2 (the link to microsoft.com is just too flaky to not cherry-pick into all supported releases) Thx @killianmuldoon ! |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.1 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #6869 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #6870 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
This PR changes the MD link checker action to only work on files modified by the PR. This will hopefully reduce disruption from MD link checker flakes on PRs. This commit also adds a periodic link-checker action that should scan all MDs on a weekly schedule and identify broken links across the repo more widely.