Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ci: use KUBERNETES_VERSION in kubeadm script #6844

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

jackfrancis
Copy link
Contributor

What this PR does / why we need it:

This PR replaces the capz-specific $CI_VERSION env var with the capi-standard $KUBERNETES_VERSION variable. This was introduced here:

#6711

Folks are seeing such side-effects since the above PR merged:

Jul 06 03:40:39 cluster-conformance-98lra3-control-plane-nhfqm cloud-init[611]: [2022-07-06 03:40:15] /usr/local/bin/ci-artifacts.sh: line 103: CI_VERSION: unbound variable

Sorry everyone, thanks @sbueringer for triaging!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 6, 2022
@jackfrancis jackfrancis force-pushed the ci-version-unbound branch from a439715 to c185d61 Compare July 6, 2022 17:26
@jackfrancis jackfrancis force-pushed the ci-version-unbound branch from c185d61 to 76c4ee6 Compare July 6, 2022 17:28
@sbueringer
Copy link
Member

Thx for the quick fix!

/lgtm
/approve

/cherry-pick release-1.2

/cc @apricote @mdbooth

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

Thx for the quick fix!

/lgtm
/approve

/cherry-pick release-1.2

/cc @apricote @mdbooth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from apricote and mdbooth July 6, 2022 17:36
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit de97e5d into kubernetes-sigs:main Jul 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 6, 2022
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #6847

In response to this:

Thx for the quick fix!

/lgtm
/approve

/cherry-pick release-1.2

/cc @apricote @mdbooth

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis deleted the ci-version-unbound branch July 6, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants