Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 runtime-sdk: add logs #6832

Merged
merged 1 commit into from
Jul 11, 2022
Merged

🌱 runtime-sdk: add logs #6832

merged 1 commit into from
Jul 11, 2022

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Jul 5, 2022

What this PR does / why we need it:

This PR adds logs in topology controller, runtime client and the extension config controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #6330

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 5, 2022
sbueringer
sbueringer reviewed Jul 6, 2022
View reviewed changes
exp/runtime/internal/controllers/extensionconfig_controller.go Outdated Show resolved Hide resolved
exp/runtime/internal/controllers/extensionconfig_controller.go Outdated Show resolved Hide resolved
exp/runtime/internal/controllers/extensionconfig_controller.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/desired_state.go Outdated Show resolved Hide resolved
internal/controllers/topology/cluster/desired_state.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jul 6, 2022
Closed
30 tasks
@ykakarap
Copy link
Contributor Author

ykakarap commented Jul 6, 2022

/retest

@ykakarap ykakarap force-pushed the runtime-sdk_logging branch from c4ec2ae to 340748a Compare July 8, 2022 00:14
sbueringer
sbueringer reviewed Jul 8, 2022
View reviewed changes
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Jul 8, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending latest nits

internal/runtime/client/client.go Outdated Show resolved Hide resolved
killianmuldoon
killianmuldoon reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me - one small question from me, and the other outstanding comments and this look good to go!

@ykakarap ykakarap force-pushed the runtime-sdk_logging branch from 340748a to 4843b49 Compare July 8, 2022 20:43
@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/lgtm

/assign @fabriziopandini

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
fabriziopandini
fabriziopandini reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6df168f into kubernetes-sigs:main Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 11, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 11, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #6889

In response to this:

/lgtm

/assign @fabriziopandini

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ykakarap @sbueringer @k8s-infra-cherrypick-robot @k8s-ci-robot @fabriziopandini @killianmuldoon