-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Run dependabot action outside of GOPATH again #6820
🌱 Run dependabot action outside of GOPATH again #6820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm @sbueringer should we backport those changes? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
I think we don't really have to. This change specifically doesn't really make sense given that dependabot only runs on main We can consider #6815, but folks usually develop on main. So it's probably not relevant if |
That being said. If someone wants to cherry-pick, I'm not opposed, I just think we don't have to. |
What this PR does / why we need it:
Now that #6815 made it possible to run
make generate
outside of GOPATH again, let's revert the workaround in the dependabot action.Will be verified via: sbueringer#65
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #6526