-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix structuredmerge filterintent to cleanup nested empty maps #6785
🐛 fix structuredmerge filterintent to cleanup nested empty maps #6785
Conversation
internal/controllers/topology/cluster/structuredmerge/filterintent_test.go
Outdated
Show resolved
Hide resolved
/cherry-pick release-1.2 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f042df6
to
08d91f6
Compare
08d91f6
to
2631a8f
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #6796 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
FilterIntent is supposed to remove all empty maps including nested maps to get consistent objects for comparison.
Currently it did only remove empty leaf maps which exist due to field removal.
Now it also removes new empty leaf maps which result from removing an empty leaf map.
Example:
Consider the following input
Consider FilterIntent to remove the path
a.b.c.d
(due to ignorePath).The current implementation would only remove the resulting empty leaf map at
a.b.c
which would result in:Actually FilterIntent should also remove
a.b
and thena
because while bubbling up they also get empty leaf maps.The result including this fix is:
/test all
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #