Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add blocking end-to-end tests for lifecycle hooks #6761

Merged
merged 1 commit into from
Jul 1, 2022
Merged

🌱 Add blocking end-to-end tests for lifecycle hooks #6761

merged 1 commit into from
Jul 1, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon [email protected]

Add blocking behaviour to the lifecycle hook e2e test introduced in #6664

Part of #6546
/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 28, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/blocking-e2e-tests branch 6 times, most recently from dada8ea to 3b0cd95 Compare June 29, 2022 13:10
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Add blocking end-to-end tests for lifecycle hooks 🌱 Add blocking end-to-end tests for lifecycle hooks Jun 29, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2022
sbueringer
sbueringer reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first round of review.

Overall I like the way it's implemented I just struggle a bit with the func names in cluster_upgrade_runtimesdk.go to be honest. I'll take a closer look on the next round

test/framework/cluster_topology_helpers.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/blocking-e2e-tests branch 3 times, most recently from e6a5c4d to 8d1dda7 Compare June 29, 2022 20:28
sbueringer
sbueringer reviewed Jun 30, 2022
View reviewed changes
test/framework/cluster_topology_helpers.go Outdated Show resolved Hide resolved
test/framework/cluster_topology_helpers.go Outdated Show resolved Hide resolved
test/framework/clusterctl/clusterctl_helpers.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Mostly nits

chrischdi
chrischdi reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, + the comments from @sbueringer 👍 great stuff 🎉

@killianmuldoon killianmuldoon force-pushed the runtimeSDK/blocking-e2e-tests branch 2 times, most recently from 0320e57 to 6a9a64c Compare June 30, 2022 15:19
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/blocking-e2e-tests branch from 6a9a64c to 659bf22 Compare June 30, 2022 15:24
sbueringer
sbueringer reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise looks great!

test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Outdated Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jun 30, 2022
Closed
8 tasks
fabriziopandini
fabriziopandini reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, just a question from my side

test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/blocking-e2e-tests branch from 659bf22 to 10de334 Compare July 1, 2022 12:00
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/blocking-e2e-tests branch from 10de334 to 2da9619 Compare July 1, 2022 12:04
@sbueringer
Copy link
Member

sbueringer commented Jul 1, 2022 •
edited
Loading

/lgtm

Great work, thx!

+/- green test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2022
@sbueringer
Copy link
Member

/cherry-pick release-1.2
/approve

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit f2aaa2b into kubernetes-sigs:main Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jul 1, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 1, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #6800

In response to this:

/cherry-pick release-1.2
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon killianmuldoon mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@killianmuldoon @sbueringer @k8s-infra-cherrypick-robot @k8s-ci-robot @chrischdi @fabriziopandini