Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🐛 fix disable verify action for cherry-pick bot #6707

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[release-1.2] 🐛 fix disable verify action for cherry-pick bot #6707

merged 1 commit into from
Jun 23, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot commented Jun 23, 2022 •
edited by sbueringer
Loading

This is an automated cherry-pick of #6705

Some more text for verify - maybe this is really the last time

/assign sbueringer

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 23, 2022
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2022
killianmuldoon
killianmuldoon approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still trying to run the verifier action on this PR 🤔 - is that expected here?

@sbueringer
Copy link
Member

sbueringer commented Jun 23, 2022 •
edited
Loading

It's still trying to run the verifier action on this PR thinking - is that expected here?

Yes. It should only change once the workflow is already in the base branch of a PR

/lgtm
/approve

(I'll test it on one another cherry-pick PR after this one is merged)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8d7ddf6 into kubernetes-sigs:release-1.2 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @killianmuldoon