-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update go-github from v33.0.0 to v45.2.0 #6703
Conversation
Hi @oscr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/test pull-cluster-api-e2e-full-main Thx! /lgtm I would not cherry-pick it back into the 1.2 branch just because it's a bump of 12 major versions and I would prefer more time to see if it breaks something. |
@sbueringer I agree 100%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer let's consider to cherry pick on 1.2 so we can get some feedback from folks validating the release |
Good point. You're right, we won't really get a lot of feedback from the change just being on main (mostly from CI, but we already have enough CI feedback already). For me it would be fine to cherry-pick as we still have some time to go and we expect infra providers to actively test our beta release Also the dependency is only used in clusterctl so the blast radius is limited |
/cherry-pick release-1.2 |
@sbueringer: new pull request created: #6723 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pr updates go-github from v33.0.0 to v45.2.0.
For reference: https://github.com/google/go-github/releases
Related issue #6687