Validate machineset before reconciling #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
It would be great to have a unit test for this behavioural change. |
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
from
172dd77 to
b886317
Compare
k8s-ci-robot
added
size/S
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
from
b886317 to
0e6bdbe
Compare
|
/test pull-cluster-api-test |
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
from
0e6bdbe to
093a79d
Compare
k8s-ci-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ingvagabund If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
9 times, most recently
from
2b2ce48 to
35d9925
Compare
k8s-ci-robot
added
size/L
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
2 times, most recently
from
b4b9985 to
8ab12f5
Compare
k8s-ci-robot
added
size/M
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
2 times, most recently
from
6fa6a53 to
d529f03
Compare
|
/test pull-cluster-api-test |
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
from
d529f03 to
7ee9873
Compare
k8s-ci-robot
added
size/L
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
from
7ee9873 to
0367fcb
Compare
Even thought the MachineSet type implements Validate() function, it's not called by default. The validation function is responsible for making sure every machine set matchLabels selector is matched with machine template labels. Given the validation is not performed by default, it is possible to create an invalid machineset that causes the machineset controller to start creating machine object one by one without any upper bound. Causing the machine controller to launch as many instances as there is machine objects.
ingvagabund
force-pushed
the
validate-machineset-in-reconsiliation
branch
from
0367fcb to
b209d7b
Compare
|
/retest |
enxebre
reviewed
Jan 16, 2019
| @@ -150,6 +150,13 @@ func (r *ReconcileMachineSet) Reconcile(request reconcile.Request) (reconcile.Re | |||
| } | |||
|
|
|||
| klog.V(4).Infof("Reconcile machineset %v", machineSet.Name) | |||
|
|
|||
| if errList := machineSet.Validate(); len(errList) > 0 { | |||
There was a problem hiding this comment.
we could consider to run and Admission Webhook for this and similar features. This is better than we have today though
enxebre
reviewed
Jan 16, 2019
| expectedRequest: reconcile.Request{NamespacedName: types.NamespacedName{Name: "invalidfoo", Namespace: "default"}}, | ||
| verifyFnc: func() { | ||
| // expecting machineset validation error | ||
| if _, err := r.Reconcile(reconcile.Request{ |
There was a problem hiding this comment.
you could also validate reconcile.Result{} here
|
overall lgtm |
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this pull request
Jan 31, 2020
Remove vestigial tokens package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even thought the MachineSet type implements Validate() function,
it's not called by default. The validation function is responsible
for making sure every machine set matchLabels selector is matched with
machine template labels. Given the validation is not performed by default,
it is possible to create an invalid machineset that causes the machineset
controller to start creating machine object one by one without any upper
bound. Causing the machine controller to launch as many instances as
there is machine objects.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
How to reproduce it? Deploy a machineset with at least one replica. Then run
kubectl editto change the machinesetmatchLabelsthe way it does not match machine template labels.Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: