🐛 Restore yq targets accidentally removed in 5785 #6681
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cherry-pick release-1.2 |
|
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -970,6 +975,9 @@ $(SETUP_ENVTEST_BIN): $(SETUP_ENVTEST) ## Build a local copy of setup-envtest. | |||
| .PHONY: $(KPROMO_BIN) | |||
| $(KPROMO_BIN): $(KPROMO) ## Build a local copy of kpromo | |||
|
|
|||
| .PHONY: $(YQ_BIN) | |||
There was a problem hiding this comment.
I'm still getting
➜ cluster-api git:(pr/6681) ./hack/get-project-maintainers.sh
make: *** No rule to make target `hack/tools/bin/yq'. Stop.
Probably because the makefile was refactored and the script runs make hack/tools/bin/yq but this just has a make yq target
There was a problem hiding this comment.
if you change /hack/get-project-maintainers.sh to
YQ="${REPO_ROOT}/hack/tools/bin/yq"
cd "${REPO_ROOT}" && make "${YQ##*/}" &>/dev/null
it should work
There was a problem hiding this comment.
fixed, it worked because first I called make yq, then the binary was already there when testing the script
|
/lgtm cancel need to fix the script to work with the new target |
k8s-ci-robot
removed
the
lgtm
fabriziopandini
force-pushed
the
restore-yq-targets
branch
from
1700781 to
5246920
Compare
|
Works for me locally now /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@fabriziopandini: new pull request created: #6682 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR restores yq targes accidentally removed by #5785
After this PR hack/get-project-maintainers.sh is back to proper functioning
/cc @CecileRobertMichon