🌱 RuntimeSDK/client: use random port for unit test server #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
force-pushed
the
pr-use-random-port
branch
from
3af8a86 to
e908084
Compare
vincepri
reviewed
Jun 17, 2022
| @@ -530,7 +528,8 @@ func TestClient_CallExtension(t *testing.T) { | |||
| validExtensionHandlerWithFailPolicy := runtimev1.ExtensionConfig{ | |||
| Spec: runtimev1.ExtensionConfigSpec{ | |||
| ClientConfig: runtimev1.ClientConfig{ | |||
| URL: pointer.String(fmt.Sprintf("https://%s/", testHostPort)), | |||
| // Set a dummy URL, in test cases where we start the test server the URL will be overridden. | |||
There was a problem hiding this comment.
Suggested change
| // Set a dummy URL, in test cases where we start the test server the URL will be overridden. | |
| // Set a fake URL, in test cases where we start the test server the URL will be overridden. |
| @@ -552,7 +551,8 @@ func TestClient_CallExtension(t *testing.T) { | |||
| validExtensionHandlerWithIgnorePolicy := runtimev1.ExtensionConfig{ | |||
| Spec: runtimev1.ExtensionConfigSpec{ | |||
| ClientConfig: runtimev1.ClientConfig{ | |||
| URL: pointer.String(fmt.Sprintf("https://%s/", testHostPort)), | |||
| // Set a dummy URL, in test cases where we start the test server the URL will be overridden. | |||
There was a problem hiding this comment.
Suggested change
| // Set a dummy URL, in test cases where we start the test server the URL will be overridden. | |
| // Set a fake URL, in test cases where we start the test server the URL will be overridden. |
| @@ -780,7 +781,8 @@ func TestClient_CallAllExtensions(t *testing.T) { | |||
| extensionConfig := runtimev1.ExtensionConfig{ | |||
| Spec: runtimev1.ExtensionConfigSpec{ | |||
| ClientConfig: runtimev1.ClientConfig{ | |||
| URL: pointer.String(fmt.Sprintf("https://%s/", testHostPort)), | |||
| // Set a dummy URL, in test cases where we start the test server the URL will be overridden. | |||
There was a problem hiding this comment.
Suggested change
| // Set a dummy URL, in test cases where we start the test server the URL will be overridden. | |
| // Set a fake URL, in test cases where we start the test server the URL will be overridden. |
sbueringer
force-pushed
the
pr-use-random-port
branch
from
e908084 to
665410a
Compare
|
@vincepri Done, PTAL |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I noticed that when running the tests locally I hit the issue that parallel running tests fail because the port is already used.
I assume Go only starts more tests (in this case of the same package) in parallel if the CPU core/thread count is high enough :)
But of course this also fails if something else is using the port locally which can easily happen with 9090.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #