🐛 Stop adding parent object owner reference for MachineHealthChecks in managed topologies #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
|
/test pull-cluster-api-e2e-full-main |
sbueringer
force-pushed
the
pr-ssa-fix-cp-mhc-ownerref-2
branch
2 times, most recently
from
3a67cad to
26711a8
Compare
k8s-ci-robot
added
size/L
sbueringer
force-pushed
the
pr-ssa-fix-cp-mhc-ownerref-2
branch
from
26711a8 to
20c496b
Compare
sbueringer
commented
Jun 17, 2022
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @killianmuldoon @fabriziopandini |
k8s-ci-robot
added
the
lgtm
sbueringer
force-pushed
the
pr-ssa-fix-cp-mhc-ownerref-2
branch
from
20c496b to
188c1e0
Compare
k8s-ci-robot
added
needs-rebase
…of ControlPlanes in topology
sbueringer
force-pushed
the
pr-ssa-fix-cp-mhc-ownerref-2
branch
from
188c1e0 to
775707a
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Discussed the PR with Killian and Fabrizio. We decided to drop the owner reference for MHC entirely as they don't seem to be necessary |
|
/test pull-cluster-api-e2e-full-main |
fabriziopandini
changed the title
|
@sbueringer I updated PR title and description to keep track of the discussion outcomes |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While testing the new release we recognized that we can simplify how we managed MachineHealthChecks in managed topologies by stopping adding parent object owner reference
According to the discussion, we can rely on MHC controller to set the ownerRef to the Cluster, thus ensuring the proper cleanup of the objects during deletion.
Also the order of operations when adding/removing MD ensures no orphan MHC will be left around in a Cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #