🌱 Add tests for external patch apply #6658
Conversation
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
changed the title
| @@ -57,11 +57,14 @@ func (t *requestItemBuilder) WithHolder(object client.Object, fieldPath string) | |||
| return t | |||
| } | |||
|
|
|||
| // uuidGenerator is defined as a package variable to enable changing it during testing. | |||
| var uuidGenerator func() types.UID = uuid.NewUUID | |||
There was a problem hiding this comment.
This is one of the things I'm not fully comfortable with - it lets us generate the UUID at runtime for testing. It's fully private, but it's not being injected properly. The alternative would be to pass it through a call chain though as this is essentially for matching patches.
There was a problem hiding this comment.
I'm fine with the current implementation and prefer it over alternatives. I've seen this pattern used before and I don't think it's too problematic.
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
runtimeSDK/test-external-patch-apply
branch
from
dc73aab to
b682941
Compare
|
/lgtm |
|
/assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
killianmuldoon
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: killianmuldoon [email protected]
Add tests to Apply using an external Patch.
Part of #6545