-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 More generic explanation about issue getting kubeconfig on certain systems using Docker #6628
Conversation
|
Welcome @RobinDeBock! |
Hi @RobinDeBock. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, a few nits
@RobinDeBock Thx can you please squash the commits? |
/ok-to-test |
@sbueringer |
I don't think you can squash via the GitHub UI, usually this is done locally via git. Do you have git setup locally and are you familiar with it? Otherwise it might be better if I squash for you and then you can take the time to learn more about Git (if you want to) |
I'm familiar with Git and got it installed locally. I just wanted to check before undoing these last commits and then squashing them, because it's quite impactful. Thanks for the suggestion though ;) |
Okay good. Just asked because otherwise I would have to start somewhere else and not at "how to squash" :) If you are on your local branch # 5 is the number of commits you want to edit
git rebase -i HEAD~5
# An editor should open, mark commits that you want squashed as "squash"
# In your case mark every commit except the first one as squash
# then write+quit
git push --force See: https://www.git-tower.com/learn/git/faq/git-squash (there's a gif below " If you mark one or more lines as "squash", they will be combined with the one above:") |
Removed mentions of Windows as the fix isn't tested Update docs/book/src/clusterctl/developers.md Co-authored-by: Stefan Büringer <[email protected]> Update docs/book/src/clusterctl/developers.md Co-authored-by: Stefan Büringer <[email protected]> Update docs/book/src/user/quick-start.md Co-authored-by: Stefan Büringer <[email protected]>
@sbueringer I pushed the changes you asked for, thanks! |
Thx! /lgtm |
/approve |
/cherry-pick release-1.2 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #6692 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Following the comment of @sbueringer #6595 (comment) I have updated the documentation regarding an issue when using Docker (Desktop) on macOS, or when using Docker Desktop on Linux (Docker Enginer works fine).
The documentation only mentioned the fix for Mac users, now the more generic explanation targets all the appriopriate users.
Which issue(s) this PR fixes:
The issue is already closed, but resulted from the lack of this information: #6595