Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ RuntimeSDK: Add Test Extension and initial e2e test #6625

Merged
merged 1 commit into from
Jun 13, 2022
Merged

✨ RuntimeSDK: Add Test Extension and initial e2e test #6625

merged 1 commit into from
Jun 13, 2022

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6549

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 10, 2022
@sbueringer sbueringer force-pushed the pr-runtime-sdk-e2e-test branch from e774146 to aec4141 Compare June 10, 2022 16:32
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 10, 2022
@sbueringer sbueringer force-pushed the pr-runtime-sdk-e2e-test branch from aec4141 to d0d277e Compare June 10, 2022 16:34
killianmuldoon
killianmuldoon reviewed Jun 10, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run the test on this PR?

@sbueringer
Copy link
Member Author

Can we run the test on this PR?

Yes, I made it part of: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/6625/pull-cluster-api-e2e-informing-main/1535299356205256704

Which means it's run on every PR just like the ClusterClass quickstart (but optional for merge)

@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jun 11, 2022
fabriziopandini
fabriziopandini reviewed Jun 12, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate how support for testing runtime extension is being added to test framework. Great work!
Looks good overall, only a couple of nits but ready to lgtm to unblock next steps

test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
test/e2e/cluster_upgrade_runtimesdk.go Show resolved Hide resolved
test/e2e/data/infrastructure-docker/v1beta1/clusterclass-quick-start-runtimesdk.yaml Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-runtime-sdk-e2e-test branch from 3f8265a to 490f972 Compare June 13, 2022 05:47
@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@chrischdi
Copy link
Member

/hold
so others can review :-)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022
@sbueringer
Copy link
Member Author

/hold cancel
I wouldn't explicitly hold as we don't have an approve yet anyway

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2022
@sbueringer sbueringer force-pushed the pr-runtime-sdk-e2e-test branch from 490f972 to 8037804 Compare June 13, 2022 13:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@sbueringer
Copy link
Member Author

Rebased on top of current main

@sbueringer sbueringer mentioned this pull request Jun 13, 2022
Merged
@fabriziopandini
Copy link
Member

Let's keep moving! looking forward to see follow up PRs to build on top of this one
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 911ad53 into kubernetes-sigs:main Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 13, 2022
@sbueringer sbueringer deleted the pr-runtime-sdk-e2e-test branch June 13, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @chrischdi @fabriziopandini @k8s-ci-robot @killianmuldoon