✨ Topology Mutation Hook: Implement external patching #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
sbueringer
force-pushed
the
pr-topology-mutation-external-only
branch
from
4d8fc83 to
6aa39f5
Compare
k8s-ci-robot
added
size/L
sbueringer
force-pushed
the
pr-topology-mutation-external-only
branch
from
6aa39f5 to
45d9755
Compare
schrej
reviewed
Jun 10, 2022
internal/controllers/topology/cluster/patches/external/external_patch_generator.go
Outdated
Show resolved
Hide resolved
sbueringer
commented
Jun 10, 2022
internal/controllers/topology/cluster/patches/external/external_patch_generator.go
Show resolved
Hide resolved
5 tasks
k8s-ci-robot
added
the
needs-rebase
killianmuldoon
force-pushed
the
pr-topology-mutation-external-only
branch
from
a74ce34 to
875d610
Compare
k8s-ci-robot
added
size/XL
killianmuldoon
force-pushed
the
pr-topology-mutation-external-only
branch
2 times, most recently
from
8770859 to
dae68ae
Compare
| @@ -361,7 +366,17 @@ func TestApply(t *testing.T) { | |||
| blueprint, desired := setupTestObjects() | |||
|
|
|||
| // If there are patches, set up patch generators. | |||
| patchEngine := NewEngine() | |||
| // FIXME(sbueringer) implement test for external patches | |||
There was a problem hiding this comment.
Current version is still missing these tests.
There was a problem hiding this comment.
Just to clarify: Plan is to add them in a follow-up PR which will be up today or tomorrow
sbueringer
force-pushed
the
pr-topology-mutation-external-only
branch
5 times, most recently
from
d7ecab4 to
2ae268f
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-topology-mutation-external-only
branch
from
2ae268f to
df5773c
Compare
Signed-off-by: Stefan Büringer [email protected] Co-authored-by: killianmuldoon <[email protected]>
sbueringer
force-pushed
the
pr-topology-mutation-external-only
branch
from
df5773c to
998bc05
Compare
|
/lgtm |
|
@sbueringer: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #6545