Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Runtime sdk/namespace selector #6619

Merged
merged 1 commit into from
Jun 13, 2022
Merged

🌱 Runtime sdk/namespace selector #6619

merged 1 commit into from
Jun 13, 2022

Conversation

killianmuldoon
Copy link
Contributor

Implementation of the namespaceSelector from the RuntimeSDK ExtensionConfig.

Part of #6330

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/namespace-selector branch from 5bcaa82 to 9e8ddf8 Compare June 9, 2022 18:10
killianmuldoon
killianmuldoon commented Jun 9, 2022
View reviewed changes
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request Jun 10, 2022
Closed
30 tasks
@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jun 10, 2022
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Runtime sdk/namespace selector 🌱 Runtime sdk/namespace selector Jun 10, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/namespace-selector branch 2 times, most recently from 9568a6c to 9aef446 Compare June 10, 2022 13:56
sbueringer
sbueringer reviewed Jun 10, 2022
View reviewed changes
internal/webhooks/runtime/extensionconfig_webhook.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed Jun 12, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, pending nits. Great job!

internal/runtime/client/client.go Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/namespace-selector branch 2 times, most recently from 26a84eb to b0dfe12 Compare June 13, 2022 13:10
sbueringer
sbueringer reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit otherwise lgtm. Thx!

internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/namespace-selector branch from b0dfe12 to b3e0b58 Compare June 13, 2022 13:47
@sbueringer
Copy link
Member

Thank you very much!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
fabriziopandini
fabriziopandini reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@chrischdi
Copy link
Member

chrischdi commented Jun 13, 2022 •
edited
Loading

/lgtm

🎉

@killianmuldoon
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9bfd3f3 into kubernetes-sigs:main Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @chrischdi @fabriziopandini