-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ RuntimeSDK: BeforeClusterCreate, BeforeClusterUpgrade implementation #6608
✨ RuntimeSDK: BeforeClusterCreate, BeforeClusterUpgrade implementation #6608
Conversation
/hold This PR should be merged after #6581 is merged. |
5897927
to
522e82c
Compare
/hold cancel |
38702fe
to
bca1040
Compare
bca1040
to
3ecb5e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, looks a lot more straightforward then what I thought (I know this PR doesn't contain the tracking stuff yet :))
I think the only bigger discussion we have is: #6608 (comment) Everything else is just details.
internal/controllers/topology/cluster/scope/hookresponsetracker.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/scope/hookresponsetracker.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/scope/hookresponsetracker.go
Outdated
Show resolved
Hide resolved
f05f8f8
to
ce026ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good a few nits, otherwise lgtm from my side
/assign @fabriziopandini
Please take a look already when you have some time
acbeed8
to
5011418
Compare
Thank you very much! /lgtm |
folks any chance we can include the issue this solves in the PR desc so it's easier to navigate across all this interrelated work? |
Done (also on the other one). I agree we should include some kind of fixes / part of / ... . We tried to do this in the Runtime SDK PRs in general, I suppose we forgot it here. |
I forgot adding the issue here. Thanks @sbueringer for adding it to the other as well. :) |
5011418
to
1739897
Compare
1739897
to
9b9187d
Compare
lgtm pending squash |
9b9187d
to
34235b0
Compare
squshed |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Things are really shaping out nicely
internal/controllers/topology/cluster/scope/hookresponsetracker.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/scope/hookresponsetracker.go
Outdated
Show resolved
Hide resolved
04d3b9e
to
6af1ea5
Compare
lgtm pending squash |
6af1ea5
to
abb8f5f
Compare
/lgtm |
Thx! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This implements 2 non-tracking lifecycle-hooks:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #6546
/area runtime-sdk