Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Bump mink8s mgmt cluster version to 1.20.2 #6597

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jun 6, 2022

What this PR does / why we need it:

In order to fix failures on #6495 I discovered that we need a fix for a SSA apply issue that merged in Kubernetes 1.20 (kubernetes/kubernetes#95680), so bumping CAPI mink8s version to 1.20.2

This will allow tests to pass.
We are considering if to add an additional restriction when using CC, to require management cluster >= v1.22 (the version where SSA went GA), but this will be discussed as part of #6495

/cc @sbueringer

@k8s-ci-robot k8s-ci-robot requested a review from sbueringer June 6, 2022 18:07
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2022
@fabriziopandini fabriziopandini changed the title ⚠️ bump mink8s mgmt cluster version to 1.20.2 ⚠️ Bump mink8s mgmt cluster version to 1.20.2 Jun 6, 2022
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 351e4be into kubernetes-sigs:main Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 6, 2022
@fabriziopandini fabriziopandini deleted the bump-mink8s-mgmt-cluster-version-to-1.20.2 branch June 11, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants