Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 cloudbuild: upgrade to latest cloudbuild image to fix image push #6585

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Jun 2, 2022

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Our image push / cloudbuild is broken since 14th May (https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/cluster-api-push-images-nightly). Not sure what happened then but looks like we can't compile kustomize with Go 1.16. This PR tries to fix this issue by bumping to a recent cloud build image which includes Go 1.17.

Notes:

  • I can reproduce locally that kustomize can't be build with Go 1.16 but works with Go 1.17
  • Just got the alert mail from Prow today, not sure if I/we missed an earlier one or there was an issue with alerting as well

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2022
@sbueringer
Copy link
Member Author

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2022
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5ceca19 into kubernetes-sigs:main Jun 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 3, 2022
@sbueringer sbueringer deleted the pr-fix-image-push branch June 3, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants