-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update docker to v20.10.16 #6552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+6 −765
Wow - I wonder why there's such a big diff for the small change?
seems like nobody ran |
On the docker side? We run it as part of |
you are right, that is what I was wondering, I see this logic to verify that here |
That project actually uses a vendor.mod instead of a go.mod, which means (I think) they have to do manual cleanups to get rid of dependencies. It looks like there's a few of those in the git history Looks like we're reaping the benefits -thanks for removing so much unneeded dependencies from the repo! 😄 /lgtm |
/assign @justinsb |
/assign @fabriziopandini |
Thx! /retitle 🌱 Update docker to v20.10.16 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.1 |
@mkumatag: #6552 failed to apply on top of branch "release-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR will update the docker dependency to the latest available version
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #