-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update docker distribution to fix go sum error #6548
Conversation
Hi @vpineda1996. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpineda1996 have you seen this build issue / can we reproduce in Cluster API?
Yup would be interesting to know what their go sum error is, but either way |
/lgtm cancel If I run |
|
This change is needed as building fails. According to https://github.com/distribution/distribution/releases/tag/v2.8.1, there are no changes between 2.8.0 and 2.8.1, the sole reason of having this new version is to fix the go.sum issue.
/ok-to-test |
@vpineda1996 I suspect I don't have the issue as the module in my local cache probably has the same checksum as the one in the go.sum file. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.1 |
@mkumatag: #6548 failed to apply on top of branch "release-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This change is needed as building fails. According to https://github.com/distribution/distribution/releases/tag/v2.8.1,
there are no changes between 2.8.0 and 2.8.1, the sole reason of having
this new version is to fix the go.sum issue.